Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManifestHermes and HEBinaryReader should be tagged #16

Open
astares opened this issue Dec 6, 2018 · 3 comments
Open

ManifestHermes and HEBinaryReader should be tagged #16

astares opened this issue Dec 6, 2018 · 3 comments
Assignees
@carolahp

Comments

@astares
Copy link
Member

astares commented Dec 6, 2018

Details in https://pharo.fogbugz.com/f/cases/22745

and change in
pharo-project/pharo#2053
@tesonep
Copy link
Collaborator

tesonep commented Dec 7, 2018

@carolahp we have to check that the code in the repo for the client part is in sync with the one in the pharo repository (after the change in the PR)

@astares
Copy link
Member Author

astares commented Dec 7, 2018

@tesonep and @carolahp: note that the change is only to tag the two classes, see the diff:
https://github.com/pharo-project/pharo/pull/2053/files

If you do the same change in the hermes repo it will be in synch regarding that point

@jecisc
Copy link
Member

jecisc commented Oct 13, 2023

This is done and can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolahp carolahp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tesonep @carolahp @astares @jecisc