Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Failing tests on the CI: Sindarin #15964

Closed
MarcusDenker opened this issue Jan 16, 2024 · 6 comments
Closed

[CI] Failing tests on the CI: Sindarin #15964

MarcusDenker opened this issue Jan 16, 2024 · 6 comments

Comments

@MarcusDenker
Copy link
Member

Bug description
These tests are failing:

osx-64 / Tests-osx-64 / testIsExecutionFinished – MacOSX64.Sindarin.Tests.SindarinDebuggerTest
osx-64 / Tests-osx-64 / testStepOverFinishedExecution – MacOSX64.Sindarin.Tests.SindarinDebuggerTest
@hernanmd hernanmd self-assigned this Feb 1, 2024
@hernanmd
Copy link
Member

hernanmd commented Feb 1, 2024

A PR in pharo-spec/ScriptableDebugger#89

@MarcusDenker
Copy link
Member Author

The PR was merged, but sindarin tests are still failing on the CI:

  • testIsExecutionFinished – MacOSX64.Sindarin.Tests.SindarinDebuggerTest
  • testStepOverFinishedExecution – MacOSX64.Sindarin.Tests.SindarinDebuggerTest

The PR was merged in master, maybe we load another branch in Pharo12?

@guillep
Copy link
Member

guillep commented Feb 8, 2024

Yes, we load Pharo12 branch.
No merges should be done in master.

@hernanmd
Copy link
Member

hernanmd commented Feb 8, 2024

I've seen https://github.com/pharo-spec/ScriptableDebugger/tree/Pharo12 is 3 commits behind master.
Do you want me to re-send the PR to Pharo12 branch in ScriptableDebugger?

GitHub
Contribute to pharo-spec/ScriptableDebugger development by creating an account on GitHub.

@jecisc
Copy link
Member

jecisc commented Feb 8, 2024

I fast forwarded P12 to master.

I don't know if the change to master should be reverted or not tho

@MarcusDenker
Copy link
Member Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants