Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #87. Update a test to use the new name of a method #90

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix #87. Update a test to use the new name of a method #90

merged 1 commit into from
Mar 29, 2024

Conversation

Inao0
Copy link

@Inao0 Inao0 commented Mar 29, 2024

SindarinDebuggerTest>>testIsAboutToInstantiateClass is now using #basicNew:header: instead of #newMethod:header: (See line 509 In the diff for actual change)
Fix #87

@MarcusDenker MarcusDenker mentioned this pull request Mar 29, 2024
Merged
@MarcusDenker
Copy link
Contributor

On the "run all tests" we have the socket tests failing and thses

LinkInstallerTest
 ✗ #testSlotOrVarLinksRemainAfterMethodModification (15ms)
 ✗ #testSlotOrVarLinksRemainAfterMethodModificationForObject (16ms)

They do not look related to the change.

@MarcusDenker MarcusDenker merged commit 1ab02dc into pharo-spec:master Mar 29, 2024
1 of 2 checks passed
@MarcusDenker MarcusDenker mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update SindarinDebuggerTest>>#testIsAboutToInstantiateClass
2 participants
@Inao0 @MarcusDenker