Remove usage of categories in MCOrganizationDefinition #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iceberg implemented its own MCPackage>>snapshot method to modify the one of Monticello. The method of Monticello was updated to use the same change as Iceberg but also it was updated to reduce the number of categories (package-tag) manipulations. I want to check here if we could use this new version for Iceberg too as a step toward getting rid of the categories in Pharo
Base the organization definition on packages and tags instead of categories. #ensureMCClassOrganisationHasCorrectStructure: has been simplified because now the organization knows the package and we do not need to do magic to ensure we have the right one IcePackageDefinition has been updated to use the package name and tag names instead of categories. This change includes pharo-vcs#1728
|
This is currently broken because of Tonel |
…izationdefinition
…izationdefinition
|
The failing tests seems to work in the latest Pharo 12. Let's restart the CI |
|
This PR is now working :) |
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Sep 16, 2023
Now that we have TonelV3 and Iceberg is been updated to never set categories in MCOrganizationDefinition, we can rely less on categories. This change needs this PR of ICeberg to be integrated in order to work well: pharo-vcs/iceberg#1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base the organization definition on packages and tags instead of categories.
#ensureMCClassOrganisationHasCorrectStructure: has been simplified because now the organization knows the package and we do not need to do magic to ensure we have the right one
IcePackageDefinition has been updated to use the package name and tag names instead of categories.
This change includes #1728