Update users of IceTipStandardAction to use #newXAction + #executeWithContext: pattern (fixes #1779) #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hContext: pattern (fixes pharo-vcs#1779) Fixes nil DNU #application errors for package reload/remove/unload, tag delete, and method version load. Also remove extraneous IceRepositoryModified when the action already has #onSuccessRepositoryModified. Add missing ^return in IceTipVersionHistoryModel>>retrieveHistory Remove IceTipStandardAction>>execute: as execution without a context will ~always fail and the pattern is to assign the action first, then the context at time of execution. No references remain in Iceberg packages, and in fact all remaining references are self-sends, so clearly aren't sent to IceTipStandardAction.
|
Thanks for the PR. |
|
Thanks! |
|
Oh there are conflicts, I'll push them to the end of the queue |
|
Hi @daniels220 I resolved the conflict locally but it seems you did not give rights to push to your branch so I cannot fix it :) |
|
Ah, I didn't realize you were going to resolve them, so I went ahead and did so. No actual conflicts—doing a back-merge in Iceberg didn't flag anything—just Git not being very syntax-aware. |
Sure no problem! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nil DNU #application errors for package reload/remove/unload, tag delete, and method version load (fixes #1779).