Skip to content

Commit

Permalink
Merge pull request #142 from phase2/develop
Browse files Browse the repository at this point in the history
2.1.1 release
  • Loading branch information
febbraro authored Feb 2, 2018
2 parents b1a93f6 + 21c9ef1 commit 85ba91b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
3 changes: 1 addition & 2 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions commands/dashboard.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ func (cmd *Dashboard) Commands() []cli.Command {
func (cmd *Dashboard) Run(ctx *cli.Context) error {
if cmd.machine.IsRunning() || util.SupportsNativeDocker() {
cmd.out.Info("Launching Dashboard")
err := cmd.LaunchDashboard(cmd.machine)
if err != nil {
if err := cmd.LaunchDashboard(cmd.machine); err == nil {
// Success may be presumed to only execute once per command execution.
// This allows calling LaunchDashboard() from start.go without success.
return cmd.Success("")
Expand Down
2 changes: 1 addition & 1 deletion commands/dns.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (cmd *DNS) StartDNS(machine Machine, nameservers string) error {
"-l", "com.dnsdock.image=outrigger",
"--name", "dnsdock",
"-p", fmt.Sprintf("%s:53:53/udp", bridgeIP),
"aacebedo/dnsdock:v1.16.1-amd64",
"aacebedo/dnsdock:v1.16.4-amd64",
"--domain=vm",
}
for _, server := range dnsServers {
Expand Down
4 changes: 2 additions & 2 deletions commands/kill.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func (cmd *Kill) Commands() []cli.Command {
return []cli.Command{
{
Name: "kill",
Usage: "Kill the docker-machine",
Usage: "Kill the docker-machine. Useful when stop does not appear to be working",
Before: cmd.Before,
Action: cmd.Run,
},
Expand All @@ -40,7 +40,7 @@ func (cmd *Kill) Run(c *cli.Context) error {
return err
}

cmd.out.Info("Killing machine '%s'", cmd.machine.Name)
cmd.out.Spin(fmt.Sprintf("Killing machine '%s'...", cmd.machine.Name))
util.StreamCommand("docker-machine", "kill", cmd.machine.Name)

// Ensure the underlying virtualization has stopped
Expand Down

0 comments on commit 85ba91b

Please sign in to comment.