Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexagonal get tile corners #6826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hexagonal get tile corners #6826

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81c8009
Fixed HexagonalGetTileCorners.js
ukamp May 25, 2024
e4a327c
Update HexagonalGetTileCorners.js
ukamp May 25, 2024
3b0e750
Update HexagonalGetTileCorners.js
ukamp May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/tilemaps/components/HexagonalGetTileCorners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ var HexagonalGetTileCorners = function (tileX, tileY, camera, layer)
}

// Sets the center of the tile into tempVec
var tempVec = new Phaser.Math.Vector2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a Vector2 and required.

var center = HexagonalTileToWorldXY(tileX, tileY, tempVec, camera, layer);

var corners = [];

// Hard-coded orientation values for Pointy-Top Hexagons only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove a useful comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is contradictory, the value is not only used for Pointy-Top Hexagons, but an aid to calculating the long diagonals. Better comment: We assume a pointy-top orientation.

var b0 = 0.5773502691896257; // Math.sqrt(3) / 3

var rotation = 0;
var hexWidth;
var hexHeight;

Expand All @@ -54,13 +54,15 @@ var HexagonalGetTileCorners = function (tileX, tileY, camera, layer)
{
hexWidth = tileWidth / 2;
hexHeight = b0 * tileHeight;
rotation = 30 * Math.PI /180;
}

for (var i = 0; i < 6; i++)
{
var angle = 2 * Math.PI * (0.5 - i) / 6;
angle += rotation;

corners.push(new Vector2(center.x + (hexWidth * Math.cos(angle)), center.y + (hexHeight * Math.sin(angle))));
corners.push(new Phaser.Math.Vector2(center.x + (hexWidth * Math.cos(angle)), center.y + (hexHeight * Math.sin(angle))));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. Require the Vector2 and use it as per the original code. You cannot guarantee Phaser will exist in the global scope.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Point

}

return corners;
Expand Down