Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade xmldom from 0.1.27 to 0.5.0 #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade xmldom from 0.1.27 to 0.5.0 #35

wants to merge 1 commit into from

Conversation

phihag
Copy link
Owner

@phihag phihag commented Mar 11, 2021

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 556/1000
Why? Recently disclosed, Has a fix available, CVSS 5.4		 XML External Entity (XXE) Injection
SNYK-JS-XMLDOM-1084960		 No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: xmldom The new version differs by 160 commits.
  • f763b00 xmldom version 0.5.0
  • d4201b9 Merge pull request from GHSA-h6q6-9hqw-rwfv
  • a4d717c Update MDN links in readme.md (#188)
  • e984b3f Update @ stryker-mutator/core -> ^4.4.1 - devDependencies (#184)
  • c762161 Update stryker monorepo (major) (#140)
  • fd47c51 Fix breaking preprocessors' directives when parsing attributes (#171)
  • baa67f5 Update xmltest -> ^1.5.0 - devDependencies (#182)
  • 64c7388 fix(dom): Escape `]]>` when serializing CharData (#181)
  • b73a965 Update eslint-config-prettier -> ^7.2.0 - devDependencies (#179)
  • 21bc17e Switch to (only) MIT license (#178)
  • ad773c9 test: Use toBe/toStrictEqual instead of toEqual (#175)
  • 23608d9 chore: Add karfau as contributor (#177)
  • dbd2171 Export DOMException; remove custom assertions; etc. (#174)
  • 8698e6b Update eslint-config-prettier -> 7 - devDependencies (#165)
  • 7aa75c7 Update nodemon -> ^2.0.7 - devDependencies (#170)
  • 8236db1 build(deps): bump node-notifier from 8.0.0 to 8.0.1 (#169)
  • 484005e Update eslint -> ^7.18.0 - devDependencies (#162)
  • c33b2f5 Update eslint-plugin-prettier -> ^3.3.1 - devDependencies (#164)
  • 5d13108 Update actions/setup-node action -> 2 - action (#167)
  • 7f32da6 Update prettier -> ^2.2.1 - devDependencies (#163)
  • d4040a7 build(deps): bump ini from 1.3.5 to 1.3.8 (#166)
  • f7b44d9 Update eslint -> ^7.12.1 - devDependencies (#157)
  • 7493052 Update jest -> ^26.6.3 - devDependencies (#161)
  • 2107a91 Update jest -> ^26.6.2 - devDependencies (#159)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

karfau added a commit to karfau/pdfform.js that referenced this pull request Dec 27, 2021
@karfau
Update dependency xmldom
88dd5f6 
Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- I used node 12 to run `npm install`.
- I executed `npm run test` on my machine without failure
- I tried to run `npm run prepublishOnly` but it failed in `make test` with one test timing out. After running `make force-install-libs` it fails in the step `make dist` (Makefile line 39), but from the error message it doesn't look like it's an issue related to this PR
- This makes phihag#35 obsolete

I'm one of the xmldom maintainers. Don't hesitate to ask me questions.

https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md
@karfau karfau mentioned this pull request Dec 27, 2021
Open
linedotstar pushed a commit to betterup/pdfform.js that referenced this pull request Aug 16, 2023
@karfau @linedotstar
Update dependency xmldom
23b9bdc 
Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- I used node 12 to run `npm install`.
- I executed `npm run test` on my machine without failure
- I tried to run `npm run prepublishOnly` but it failed in `make test` with one test timing out. After running `make force-install-libs` it fails in the step `make dist` (Makefile line 39), but from the error message it doesn't look like it's an issue related to this PR
- This makes phihag#35 obsolete

I'm one of the xmldom maintainers. Don't hesitate to ask me questions.

https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phihag @snyk-bot