Update dependency xmldom #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0: GHSA-5fg8-2547-mr8q The reason is that the maintainers were forced to switch to a scoped package since 0.7.0: xmldom/xmldom#271 - I used node 12 to run `npm install`. - I executed `npm run test` on my machine without failure - I tried to run `npm run prepublishOnly` but it failed in `make test` with one test timing out. After running `make force-install-libs` it fails in the step `make dist` (Makefile line 39), but from the error message it doesn't look like it's an issue related to this PR - This makes phihag#35 obsolete I'm one of the xmldom maintainers. Don't hesitate to ask me questions. https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from package
xmldomto@xmldom/xmldom, which resolves the security issue present in latest xmldom version 0.6.0:GHSA-5fg8-2547-mr8q
The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
xmldom/xmldom#271
npm install.npm run teston my machine without failurenpm run prepublishOnlybut it failed inmake testwith one test timing out. After runningmake force-install-libsit fails in the stepmake dist(Makefile line 39), but from the error message it doesn't look like it's an issue related to this PRI'm one of the xmldom maintainers. Don't hesitate to ask me questions.
https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md