Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency xmldom #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependency xmldom #39

wants to merge 1 commit into from

Commits on Dec 27, 2021

  1. Update dependency xmldom 

    Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- I used node 12 to run `npm install`.
- I executed `npm run test` on my machine without failure
- I tried to run `npm run prepublishOnly` but it failed in `make test` with one test timing out. After running `make force-install-libs` it fails in the step `make dist` (Makefile line 39), but from the error message it doesn't look like it's an issue related to this PR
- This makes phihag#35 obsolete

I'm one of the xmldom maintainers. Don't hesitate to ask me questions.

https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md
    @karfau
    karfau committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    88dd5f6 View commit details
    Browse the repository at this point in the history