Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detection of login finishing #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Plyb
Copy link

@Plyb Plyb commented Jul 24, 2022

The issue was that the landing page for LCR has changed to no longer include ids on any of the elements. Luckily though, they have a custom element we can wait for.

I also changed how the settings on the webdriver work since the default was not working on my machine.

@SpencerMKSmith
Copy link

+1 Thanks for this.

Please pull this into master.

@adamarnesen
Copy link

looks like the element that @Plyb was looking for to wait for logon to complete doesn't exist anymore on the LCR main page (at least not for me). Recommend abandoning this PR

@SpencerMKSmith
Copy link

I've fixed it in my fork: https://github.com/SpencerMKSmith/LCR-API-2

Also I've been trying to set it up with Docker, which needed the repo updated with Pip so it's available under lcr-api-2 now.

@adamarnesen
Copy link

I think there has been an additional change since your fork was updated. I've been working on it in my own fork as well if you want to take a look: https://github.com/adamarnesen/LCR-API-Plus

@adamarnesen
Copy link

I think there has been an additional change since your fork was updated. I've been working on it in my own fork as well if you want to take a look: https://github.com/adamarnesen/LCR-API-Plus

Actually, after a double check, looks like your version is working. I must have had a typo or something earlier when I tried it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants