Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tparse for test output #152

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Nov 26, 2023

Maybe we should provide a tool installer in the magefile? Like mage setup or mage install and it installs all required CLI tools in the versions we use?

Or maybe better to change the magefile to check if tparse is installed, and only use it when it is?

@philippgille philippgille changed the base branch from master to improve-error-handling-in-magefile November 26, 2023 21:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d158ac5) 65.26% compared to head (58db5c8) 65.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           improve-error-handling-in-magefile     #152   +/-   ##
===================================================================
  Coverage                               65.26%   65.26%           
===================================================================
  Files                                      25       25           
  Lines                                    2096     2096           
===================================================================
  Hits                                     1368     1368           
  Misses                                    601      601           
  Partials                                  127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille merged commit 35a7ebb into improve-error-handling-in-magefile Dec 3, 2023
8 checks passed
@philippgille
Copy link
Owner Author

Accidentally merged this into another feature branch instead of master. That branch was already merged into master, so no harm done. Still removed the added commits as the branch wasn't deleted yet and should be clean.

New PR for merge to master: #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants