Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic when encountering web transports #192

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: don't panic when encountering web transports #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64421ca
fix: don't panic when encountering web transports
sruehl Jan 5, 2024
b98cd08
fix: when server returns unknown negotiation transport return a error
sruehl Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions httpconnection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package signalr
import (
"context"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
Expand Down Expand Up @@ -127,6 +128,7 @@ func NewHTTPConnection(ctx context.Context, address string, options ...func(*htt
switch {
case negotiateResponse.hasTransport("WebTransports"):
// TODO
return nil, errors.New("support for WebTransports not implemented yet")

case httpConn.hasTransport(TransportWebSockets) && negotiateResponse.hasTransport(TransportWebSockets):
wsURL := reqURL
Expand Down Expand Up @@ -178,6 +180,9 @@ func NewHTTPConnection(ctx context.Context, address string, options ...func(*htt
if err != nil {
return nil, err
}

default:
return nil, fmt.Errorf("transport not configured or unknown negotiation transports: %v", negotiateResponse.AvailableTransports)
}

return conn, nil
Expand Down
Loading