Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error handling without invoking the google test test environment #104

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

daantimmer
Copy link
Collaborator

No description provided.

@daantimmer daantimmer requested a review from a team as a code owner November 9, 2024 23:31
Copy link

github-actions bot commented Nov 9, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 6 0 0.04s
✅ CPP clang-format 73 0 0 0.35s
✅ DOCKERFILE hadolint 1 0 0.14s
✅ JSON jsonlint 8 0 0.15s
✅ JSON prettier 8 6 0 0.7s
✅ MARKDOWN markdownlint 4 1 0 1.03s
⚠️ MARKDOWN markdown-link-check 4 2 19.51s
✅ MARKDOWN markdown-table-formatter 4 1 0 0.21s
✅ REPOSITORY checkov yes no 15.15s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 14.19s
✅ REPOSITORY ls-lint yes no 0.08s
✅ REPOSITORY secretlint yes no 1.43s
✅ REPOSITORY trivy yes no 7.54s
✅ REPOSITORY trivy-sbom yes no 0.18s
✅ REPOSITORY trufflehog yes no 2.39s
⚠️ SPELL lychee 49 1 1.05s
✅ YAML prettier 10 0 0 0.87s
✅ YAML v8r 10 0 6.73s
✅ YAML yamllint 10 0 0.29s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

"sonarlint.connectedMode.project": {
"connectionId": "philips-software",
"projectKey": "philips-software_amp-cucumber-cpp-runner"
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

Suggested change
}
],
"C/C++ Include Guard.Macro Type": "Filepath",
"C/C++ Include Guard.Path Depth": 1,
"C/C++ Include Guard.Remove Extension": false,
"C/C++ Include Guard.Comment Style": "None",
"C/C++ Include Guard.Path Skip": 0,
"testMate.cpp.test.executables": "${workspaceFolder}/.build/**/*{test,Test,TEST}*",
"sonarlint.connectedMode.project": {
"connectionId": "philips-software",
"projectKey": "philips-software_amp-cucumber-cpp-runner"
}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

"id": "tag",
"description": "Enter the tag to run",
"type": "pickString",
"options": [
"@smoke",
"@rule1 or @smoke",
"@keyword-asterisk",
"@result:UNDEFINED",
"@result:FAILED",
"@fail_feature"
]
},
{
"id": "features",
"description": "Enter the tag to run",
"type": "pickString",
"options": [
"cucumber_cpp/example/features",
"cucumber_cpp/acceptance_test/features"
]
}
],
"configurations": [
{
"name": "(gdb) Launch",
"type": "cppdbg",
"request": "launch",
"program": "${command:cmake.launchTargetPath}",
"args": [
"run",
"--feature",
"${input:features}",
"--report",
"console",
"junit-xml",
// "--com",
// "COMx",
// "--nordic",
"--tag",
"${input:tag}"
],
"stopAtEntry": false,
"cwd": "${workspaceFolder}",
"environment": [],
"externalConsole": false,
"MIMode": "gdb",
"setupCommands": [
{
"description": "Enable pretty-printing for gdb",
"text": "-enable-pretty-printing",
"ignoreFailures": true
}
]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

"cmake.useCMakePresets": "always",
"cucumberautocomplete.steps": [
"cucumber_cpp/example/steps/*.cpp",
"cucumber_cpp/acceptance_test/steps/*.cpp"
],
"cucumberautocomplete.gherkinDefinitionPart": "(GIVEN|WHEN|THEN|STEP)\\(",
"cucumberautocomplete.customParameters": [
{
"parameter": "R\"(",
"value": "\""
},
{
"parameter": ")\"",
"value": "\""
}
],
"C/C++ Include Guard.Macro Type": "Filepath",
"C/C++ Include Guard.Path Depth": 1,
"C/C++ Include Guard.Remove Extension": false,
"C/C++ Include Guard.Comment Style": "None",
"C/C++ Include Guard.Path Skip": 0,
"testMate.cpp.test.executables": "${workspaceFolder}/.build/**/*{test,Test,TEST}*",
"sonarlint.connectedMode.project": {
"connectionId": "philips-software",
"projectKey": "philips-software_amp-cucumber-cpp-runner"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MegaLinter] reported by reviewdog 🐶

// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"label": "bats",
"type": "shell",
"command": "bats --formatter junit cucumber_cpp/acceptance_test/test.bats | tee test-report.xml",
"problemMatcher": []
}
]

Copy link

github-actions bot commented Nov 9, 2024

Test Results

0 tests   - 20   0 ✅  - 20   0s ⏱️ -2s
0 suites  -  1   0 💤 ± 0 
0 files    -  1   0 ❌ ± 0 

Results for commit 72f4ba2. ± Comparison against base commit 4d66391.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28.6% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@BartKerkhoff
Copy link

I've confirmed that this PR also fixes PR #101 and issue #102. Just closed those other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants