Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ci work in fork. #16

Open
JeroenKnoops opened this issue Nov 20, 2019 · 2 comments
Open

Make ci work in fork. #16

JeroenKnoops opened this issue Nov 20, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@JeroenKnoops
Copy link
Member

Currently the CI scripts fail in forks.

This can cause issues which can only be found when:

  1. Running it locally
  2. Merging it into the upstream
@JeroenKnoops
Copy link
Member Author

Maybe we can do something when the mandatory parameters (like DOCKER_ORGANIZATION) are not set. If not set, set a good default and only run the build and not the push or something like that...

@JeroenKnoops
Copy link
Member Author

In docker_build_and_push.sh we check if we need to publish the docker image to dockerhub.
We might build an extra check there.

Check the first part of repository name ( github.repository : f.e. philips-software/docker-ci-scripts ) with the GITHUB_ORGANIZATION variable. If you have forked it, this will be different, therefore you don't want to push it to dockerhub.

@JeroenKnoops JeroenKnoops added the bug Something isn't working label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant