Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Need code review and want to understand my hack about height=0px #285

Open
nsisodiya opened this issue Dec 1, 2020 · 1 comment
Open

Comments

@nsisodiya
Copy link

My 50 lines of html/css code is available at - https://github.com/nsisodiya/layout/blob/main/src/App.js
and the above code is deployed at https://www.narendrasisodiya.com/layout/

Layout is working well as expected but I have few things to share.

  • need code review.
  • I have to use height 0px at one DOM element. Its my hack and I don't know how it is working. If I remove it, things break. is it a right way. what is alternate?
  • I am not using calc and trying stuff using just pure css.
  • is there any better way to do such simple layout.
  • I have to use flex-grow flex all the time in entire DOM hierarchy. is this right way to use flex-grow so many times.
@garrettw
Copy link

garrettw commented Dec 7, 2020

Are you intending to submit a new flexbox bug + workaround that is not in the list?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants