Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed head menu #313

Merged
merged 11 commits into from
Jul 26, 2023
Merged

changed head menu #313

merged 11 commits into from
Jul 26, 2023

Conversation

oxfordblucher
Copy link
Contributor

@oxfordblucher oxfordblucher commented Apr 4, 2023 •
edited
Loading

Pull Request

Change Summary

Changed Head + Sidebar to Head + Dropdown menu per Figma.

Change Reason

Design changes.

Verification [Optional]

Screenshot 2023-04-04 at 17-30-30 PHLASK
Screenshot 2023-04-04 at 17-37-55 PHLASK

Related Issue: #301

@oxfordblucher oxfordblucher requested a review from RNR1 April 4, 2023 21:32
@gcardonag
Copy link
Contributor

This looks slick, thank you! One note for adjustment:
Could the Head be rendered such that it shows as the original view in the develop branch when the user is on mobile? The design for mobile will still use the Head anchored to the top. For an example on splitting the views, you can use the Toolbar component, which uses isMobile to render the toolbar differently for desktop/mobile.

@oxfordblucher oxfordblucher marked this pull request as draft April 5, 2023 00:35
@oxfordblucher oxfordblucher marked this pull request as ready for review June 27, 2023 23:12
gcardonag
gcardonag approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@gcardonag gcardonag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new Header! It looks great 🎉

@gcardonag gcardonag merged commit aa833d7 into develop Jul 26, 2023
4 checks passed
@tomporvaz tomporvaz mentioned this pull request Aug 15, 2023
Closed
@tomporvaz
Copy link
Contributor

For issue #301

@tomporvaz tomporvaz linked an issue Aug 15, 2023 that may be closed by this pull request
Create V.2 Head+SideBar (Desktop) #301
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcardonag gcardonag gcardonag approved these changes

@RNR1 RNR1 Awaiting requested review from RNR1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create V.2 Head+SideBar (Desktop)
3 participants
@oxfordblucher @gcardonag @tomporvaz