322 update the wording on the phlask button on desktop #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button in toolbar with PhlaskButton
… button in toolbar with PhlaskButton
|
@gcardonag I noticed in Logan's presentation from the Design Circle on 7/18 that most of the screenshots had the button labeled 'Nearest Me' instead of 'Near Me'. Is that something we can check on before reviewing this pull request? |
Good catch! I'll ask about this in the #phlask_design channel |
gcardonag
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Created PhlaskButton.svg with 'Near Me' text and replaced 'PHLASK' button (phlaskWater.svg) in Toolbar.js component with PhlaskButton.svg.
Change Reason
Users can sometimes be confused around the purpose of the PHLASK text and what the button does. In response, we would like to change the PHLASK button text to "Near Me" (#322).
Verification [Optional]
Previous button text ('PHLASK')
Updated button text ('Near Me')
Related Issue: #322