Tomporvaz/add site button #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNR1
requested changes
Aug 1, 2023
src/components/Toolbar/Toolbar.js
Outdated
| <Typography style={{ textTransform: 'none' }} fontSize={'small'}> | ||
| Resources | ||
| </Typography> | ||
| <Typography fontSize={'small'}>Resources</Typography> |
There was a problem hiding this comment.
Curly braces are not necessary for the fontSize prop:
Suggested change
| <Typography fontSize={'small'}>Resources</Typography> | |
| <Typography fontSize="small">Resources</Typography> |
src/components/Toolbar/Toolbar.js
Outdated
| <Typography style={{ textTransform: 'none' }} fontSize={'small'}> | ||
| Filter | ||
| </Typography> | ||
| <Typography fontSize={'small'}>Filter</Typography> |
There was a problem hiding this comment.
Same here:
Suggested change
| <Typography fontSize={'small'}>Filter</Typography> | |
| <Typography fontSize="small">Filter</Typography> |
src/components/Toolbar/Toolbar.js
Outdated
| <Typography style={{ textTransform: 'none' }} fontSize={'small'}> | ||
| Search | ||
| </Typography> | ||
| <Typography fontSize={'small'}>Search</Typography> |
There was a problem hiding this comment.
Same here
Suggested change
| <Typography fontSize={'small'}>Search</Typography> | |
| <Typography fontSize="small">Search</Typography> |
src/components/Toolbar/Toolbar.js
Outdated
| }} | ||
| > | ||
| <ContributeIcon /> | ||
| <Typography style={{ textTransform: 'none' }} fontSize={'small'}> | ||
| Contribute | ||
| <Typography noWrap fontSize={'small'}> |
There was a problem hiding this comment.
Same here:
Suggested change
| <Typography noWrap fontSize={'small'}> | |
| <Typography noWrap fontSize="small"> |
|
@RNR1 I have removed the all of the curly brackets requested, and I also found more in the mobile code. Searching for curly brackets, I realized that the toolbar is duplicated for mobile, so I updated the contribute button on mobile too. I think this is complete, but let me know if there is anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request 323
Change Summary
Changed the Contribute button text to Add Site
Moved textTransform: none up to button sx
Change Reason
Changed to avoid confusion about contributing information not money.
Verification [Optional]
Related Issue: #323