Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tomporvaz/add site button #331

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Tomporvaz/add site button #331

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01bf2df
Changed the Contribute button in Toolbar.js to say Add Site
tomporvaz Jul 19, 2023
2014066
Moved noWrap inline style to typography prop noWrap and moved textTra…
tomporvaz Jul 19, 2023
6656639
Removed curly braces from fontSize = 'small'
tomporvaz Aug 8, 2023
01b056c
Updated mobile ContributeButton to Add Site, and corrected more curly…
tomporvaz Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/components/Toolbar/Toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ function Toolbar(props) {
sx={{
display: 'flex',
minWidth: '188px',
flexDirection: 'column'
flexDirection: 'column',
textTransform: 'none'
}}
>
<PhlaskWater />
Expand All @@ -215,51 +216,49 @@ function Toolbar(props) {
sx={{
width: '100%',
display: 'flex',
flexDirection: 'column'
flexDirection: 'column',
textTransform: 'none'
}}
>
<ResourceIcon />
<Typography style={{ textTransform: 'none' }} fontSize={'small'}>
Resources
</Typography>
<Typography fontSize={'small'}>Resources</Typography>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces are not necessary for the fontSize prop:

Suggested change
<Typography fontSize={'small'}>Resources</Typography>
<Typography fontSize="small">Resources</Typography>

</IconButton>
<IconButton
variant="blue"
sx={{
width: '100%',
display: 'flex',
flexDirection: 'column'
flexDirection: 'column',
textTransform: 'none'
}}
>
<FilterIcon />
<Typography style={{ textTransform: 'none' }} fontSize={'small'}>
Filter
</Typography>
<Typography fontSize={'small'}>Filter</Typography>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
<Typography fontSize={'small'}>Filter</Typography>
<Typography fontSize="small">Filter</Typography>

</IconButton>
<IconButton
variant="blue"
sx={{
width: '100%',
display: 'flex',
flexDirection: 'column'
flexDirection: 'column',
textTransform: 'none'
}}
>
<SearchIcon />
<Typography style={{ textTransform: 'none' }} fontSize={'small'}>
Search
</Typography>
<Typography fontSize={'small'}>Search</Typography>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Suggested change
<Typography fontSize={'small'}>Search</Typography>
<Typography fontSize="small">Search</Typography>

</IconButton>
<IconButton
variant="blue"
sx={{
width: '100%',
display: 'flex',
flexDirection: 'column'
flexDirection: 'column',
textTransform: 'none'
}}
>
<ContributeIcon />
<Typography style={{ textTransform: 'none' }} fontSize={'small'}>
Contribute
<Typography noWrap fontSize={'small'}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
<Typography noWrap fontSize={'small'}>
<Typography noWrap fontSize="small">

Add Site
</Typography>
</IconButton>
</Box>
Expand Down