Adds height to the .halfInfo class #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maci29
commented
Aug 8, 2023
| $lighter-grey: #E9EEF4; | ||
| $dark-grey: #2d3748; | ||
| $light-grey: #60718c; | ||
| $lighter-grey: #e9eef4; |
There was a problem hiding this comment.
I think my prettier automatically changed these. 😳 Does that matter?
a-maci29
commented
Aug 8, 2023
|
|
||
| .halfInfo { | ||
| & * { | ||
| margin: 0; | ||
| font-size: 14px; | ||
| } | ||
| height: 100vh; | ||
| } |
There was a problem hiding this comment.
The only actual code change: this worked on my browser when I set the view to responsive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #286
Adds
100vhto the height of the.halfInfoclass.Should allow the modal to take up the full height of the screen on mobile once a marker has been expanded.