Implements the Verification System #458

vontell · 2024-06-22T20:03:55Z

Implements a temporary verification system that allows users to verify and un-verify resources. Please message a PHLASK convener for the password.

Also does the following:

Attaches an id to resources within the UI for mapping back to Firebase.
Updates the regex for website submissions to allow for more website types.
Updates the verification data schema type.

RNR1

First pass!

RNR1 · 2024-07-09T23:28:23Z

src/actions/actions.js

@@ -54,6 +61,13 @@ export const pushNewResource = newResource => ({
  newResource
 });

+// Handles the case where an existing resource is updated from the submission form
+export const UPDATE_EXISTING_RESOURCE = 'UPDATE_EXISTING_RESOURCE';
+export const updateExistingResource = updatedResource => ({


Suggested change

export const updateExistingResource = updatedResource => ({

export const updateExistingResource = createAction('UPDATE_EXISTING_RESOURCE');

RNR1 · 2024-07-09T23:31:00Z

src/reducers/filterMarkers.js

@@ -97,6 +97,16 @@ export default (state = initialState, act) => {
        allResources: [...state.allResources, act.newResource]
      };

+    case actions.UPDATE_EXISTING_RESOURCE:


Suggested change

case actions.UPDATE_EXISTING_RESOURCE:

case actions.updateExistingResource.type:

allResources: state.allResources.map(resource =>

resource.id === act.payload.id

? act.payload

: resource

)

RNR1 · 2024-07-09T23:32:16Z

src/components/Verification/VerificationButton.jsx

+                  <p>Your change has been recorded. Thanks!</p>
+                  <Button
+                    onClick={closeModal}
+                    style={{


use sx with MUI components

RNR1 · 2024-07-09T23:32:53Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    CLOSE


nit: MUI buttons by default are uppercase - but I'm not sure if we overridden this in the theme

RNR1 · 2024-07-09T23:33:06Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    CANCEL


nit: MUI buttons by default are uppercase - but I'm not sure if we overridden this in the theme

RNR1 · 2024-07-09T23:33:31Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    MARK AS INACTIVE


nit: MUI buttons by default are uppercase - but I'm not sure if we overridden this in the theme

RNR1 · 2024-07-09T23:33:35Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    MARK AS UNVERIFIED


nit: MUI buttons by default are uppercase - but I'm not sure if we overridden this in the theme

Got it - fixed.

RNR1 · 2024-07-09T23:33:43Z

src/components/Verification/VerificationButton.jsx

+                  </Button>
+                  <Button
+                    onClick={markAsInactive}
+                    style={{


sx for MUI components

RNR1 · 2024-07-09T23:34:23Z

src/components/Verification/VerificationButton.jsx

+              <Input
+                placeholder="The admin password"
+                style={{ width: '100%', marginBottom: '10px' }}
+                type="text"


nit: use type="password"

RNR1 · 2024-07-09T23:37:07Z

src/components/Verification/VerificationButton.jsx

+                </Button>
+                <Button
+                  onClick={() => {
+                    if (btoa(password) == PASSWORD) {


nit: use ===

Good catch, fixed!

vontell

@RNR1 back to you!

vontell · 2024-07-16T22:59:30Z

src/components/Verification/VerificationButton.jsx

+                  </Button>
+                  <Button
+                    onClick={markAsInactive}
+                    style={{


vontell · 2024-07-16T22:59:42Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    MARK AS INACTIVE


vontell · 2024-07-16T22:59:55Z

src/components/Verification/VerificationButton.jsx

+                  </Button>
+                  <Button
+                    onClick={closeModal}
+                    style={{


vontell · 2024-07-16T23:00:00Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    CANCEL


vontell · 2024-07-16T23:00:04Z

src/components/Verification/VerificationButton.jsx

+                  <p>Your change has been recorded. Thanks!</p>
+                  <Button
+                    onClick={closeModal}
+                    style={{


vontell · 2024-07-16T23:00:08Z

src/components/Verification/VerificationButton.jsx

+                      width: '100%'
+                    }}
+                  >
+                    CLOSE


vontell · 2024-07-16T23:02:01Z

src/reducers/filterMarkers.js

@@ -97,6 +97,16 @@ export default (state = initialState, act) => {
        allResources: [...state.allResources, act.newResource]
      };

+    case actions.UPDATE_EXISTING_RESOURCE:


RNR1 · 2024-07-23T23:34:19Z

src/actions/actions.js

@@ -48,6 +53,10 @@ export const pushNewResource = newResource => ({
  newResource
 });

+// Handles the case where an existing resource is updated from the submission form
+export const UPDATE_EXISTING_RESOURCE = 'UPDATE_EXISTING_RESOURCE';


The action type is not necessary anymore! You can use

updateExistingResource.type

gcardonag

A few minor changes that should not impact functionality and this will be good to go!

gcardonag · 2024-07-23T23:41:08Z

src/components/Verification/VerificationButton.jsx

+              </p>
+              <Input
+                placeholder="Your name"
+                style={{ width: '100%', marginBottom: '10px' }}


Similar to other mui components, we should use the sx attribute here in place of style

gcardonag · 2024-07-23T23:41:14Z

src/components/Verification/VerificationButton.jsx

+              />
+              <Input
+                placeholder="The admin password"
+                style={{ width: '100%', marginBottom: '10px' }}


Similar to other mui components, we should use the sx attribute here in place of style

gcardonag · 2024-07-23T23:41:25Z

src/components/Verification/VerificationButton.jsx

+                  style={{
+                    flex: 1,
+                    backgroundColor: 'gray',
+                    color: 'white',
+                    borderRadius: '4px',
+                    padding: '4px'
+                  }}


Similar to other mui components, we should use the sx attribute here in place of style

gcardonag · 2024-07-23T23:41:35Z

src/components/Verification/VerificationButton.jsx

+                  style={{
+                    flex: 1,
+                    backgroundColor: 'blue',
+                    color: 'white',
+                    borderRadius: '4px',
+                    padding: '4px'
+                  }}


Similar to other mui components, we should use the sx attribute here in place of style

…fication

gcardonag

Approved, thanks for making all of those changes! ✅

gcardonag

🧹

vontell added 4 commits June 22, 2024 15:23

WIP verification feature

d75f23c

Merge develop

f3341fa

Working verification system

57da4d6

Correct website regrex

0d19902

vontell requested review from RNR1 and gcardonag June 23, 2024 18:52

Remove print statement

ed22b59

vontell mentioned this pull request Jun 23, 2024

Add temporary ability to verify resources #446

Closed

tomporvaz linked an issue Jun 25, 2024 that may be closed by this pull request

Add temporary ability to verify resources #446

Closed

vontell requested review from tayloraj10 and kdmonroe June 25, 2024 23:35

RNR1 reviewed Jul 9, 2024

View reviewed changes

vontell and others added 3 commits July 9, 2024 20:01

Merge develop

de5acf0

Merge branch 'develop' of github.com:phlask/phlask-map into verification

7db6cdf

Address PR comments

f9f13b3

vontell commented Jul 16, 2024

View reviewed changes

Fixes test data to ensure functional tests continue to pass

edb708d

RNR1 reviewed Jul 23, 2024

View reviewed changes

gcardonag requested changes Jul 23, 2024

View reviewed changes

vontell added 2 commits July 23, 2024 20:00

Use sx

fa72f79

Merge branch 'verification' of github.com:phlask/phlask-map into veri…

da20fce

…fication

gcardonag approved these changes Jul 24, 2024

View reviewed changes

Fix issue

a61830b

gcardonag approved these changes Jul 24, 2024

View reviewed changes

gcardonag merged commit b813345 into develop Jul 24, 2024
4 checks passed

	export const updateExistingResource = updatedResource => ({
	export const updateExistingResource = createAction('UPDATE_EXISTING_RESOURCE');

-    case actions.UPDATE_EXISTING_RESOURCE:
+    case actions.updateExistingResource.type:
+      allResources: state.allResources.map(resource =>
+          resource.id === act.payload.id
+            ? act.payload
+            : resource
+        )

Implements the Verification System #458

Implements the Verification System #458

Conversation

vontell commented Jun 22, 2024 • edited Loading

RNR1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vontell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gcardonag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gcardonag left a comment

Choose a reason for hiding this comment

gcardonag left a comment

Choose a reason for hiding this comment

vontell commented Jun 22, 2024 •

edited

Loading