Updated spacing below expanded toolbar and below subtitles #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcardonag
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@tomporvaz , this change looks good for mobile! Since this is a response to a design review, I figured I should call out that the styles referenced here affect both desktop and mobile. The spacing between the share button and the location image are different between the mobile vs desktop wireframes, so we should confirm with the design team if this updated spacing is ok for both desktop and mobile implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
addressing selectedTap modal design review, issue #423
Change Summary
Change Reason
design review
Related Issue: closes #423