Show warning if view_template
method is not defined on Phlex class
#828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just upgraded Phlex to the latest 2.x rc in a Rails app and after bumping the
phlex
andphlex-rails
versions the app would boot, the pages would render but all components would just render out as empty strings, since none of the components defined the newview_template
method.This pull request adds a warning to the rendered component output so that you know what's going on when you are upgrading.
Feel free to close this pull request if you feel like there's no place for this in Phlex.