clear private HOOK_ID as soon as hook is destroyed #3500
Merged
+138
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3496. When navigating from a sticky LiveView to another page that contains a hook on an element with the same id, morphdom would merge the old element into the new one and still find the old HOOK_ID in the element's DOM.private data, leading to the new hook not initializing properly.
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3496.
When navigating from a sticky LiveView to another page that contains a hook on an element with the same id, morphdom would merge the old element into the new one and still find the old HOOK_ID in the element's DOM.private data, leading to the new hook not initializing properly.