You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having used this very helpful program to download a few dozen animes from Aniworld i found a few things that i think could be improved, but i didn't want to create a new issue for each of these as that would just spam the issues tab.
it would be nice if the UI had 2 extra buttons above the episode selector for "select all" and "select none"
with the idea of course being that if you want to download a whole anime you don't need to manually select every episode indivitually, you can just use the "select all" button instead.
the program seems to redownload files. i noticed this when downloading yu-gi-oh, where it would time out at lets say episode 19, and then when i relaunch the command it would take quite a while to get back to where it left off despite every episode up to 19 already being fully downloaded. one time it even timed out again at an episode that was already fully downloaded... which shouldn't be possible.
so yea it'd be a nice optimization if it were to quickly skip already downloaded files.
speaking of timing out, i propose a new "retry" command line option where you can tell the program how many times it should retry to download a file (and how long to wait before each try) before giving up and exiting with an error.
just a general QoL addition so you can be sure it will try a little harder and not have it start downloading 100 animes, only to come back a few hours later to realize it stopped at episode 2 of the first one because it timed out.
episode selection with the commandline could also use an overhaul. being able to use a file instead of everything having to be in the command is already great, especially since you can specify whole seasons and animes with it.
but if you just want a select few episodes you need to specify the full URL to each of them, which is just... why???
why couldn't it just take the base URL to the anime, for example "https://aniworld.to/anime/stream/inuyasha" and then you give it a seperate formatted string to specify a list/range of episodes to download, for example: "S1E1" would only download season 1 episode 1 of the above specified anime "S2" would download the entirety of season 2 "S1E10-S2E1" would download every episode between (and including) season 1 episode 10 and season 2 episode 1 "S1, S3E10, S3E12" would download all of season 1, and season 3 episodes 10 and 12
obviously parsing such a string takes quite a bit of effort and time to implement, but since it's python i would assume there to be a few dozen libaries for that already, which would help.
really minor detail, but it would be a good addition to have season/episode numbers in the output files extended with 0's.
so for example if you have an anime with 100 episodes in a season (1-100) then all episode numbers in the file names should be 3 digits wide like so: S1E001, S1E002, ..., S1E015, S1E016, S1E017, ..., S1E100
with the reason being that it makes sure the files are sorted in the correct order on whatever device you want to watch them on. this comes from both myself and a friend of mine, he watches the downloaded stuff on his TV via a USB drive and i watch it via VLC by opening the whole folder with it.
in both cases the episodes get sorted like so:
haven't found much time for aniworld in the last couple of weeks.
I think that those are all great new additions to the current implementation and it's fine spamming the issues tab with those separately as It lets me commit using separate issue mentions about each feature I work on.
I'll look forward to look at these but I really want to concentrate on the next branch too. It really isn't that much left to do only porting some basic functionality that is already written from the main branch into the next and there I have already planed to implement a new function that can help adding episodes differently than the whole link already.
The UI changes you mentioned will be only worked in the next branch though as It's really messy in the main branch and unmaintainable lol. I fixed some spacing stuff and height crashes but also added dynamically allocated episode list height to it too.
Redownloading shouldn't happen to the episode itself though as ytdlp itself should check for existing files but you are right until it gets the link it needs, it can definitely take time and timeout. This needs to be implemented before doing literally anything and shouldn't require a connection at all before downloading files that could exist.
I don't know why a basic retry option isn't implemented yet as that's a long complain already anyways for mass downloading.
Same goes for zero leading I also noticed this myself when watching and it's really just one line to change.
It would be awesome if you can create those issues separately as enhancements so I can track new changes to the issues.
Thank you and I will keep it up for sure, just been and will be from home for another week.
Having used this very helpful program to download a few dozen animes from Aniworld i found a few things that i think could be improved, but i didn't want to create a new issue for each of these as that would just spam the issues tab.
it would be nice if the UI had 2 extra buttons above the episode selector for "select all" and "select none"
with the idea of course being that if you want to download a whole anime you don't need to manually select every episode indivitually, you can just use the "select all" button instead.
the program seems to redownload files. i noticed this when downloading yu-gi-oh, where it would time out at lets say episode 19, and then when i relaunch the command it would take quite a while to get back to where it left off despite every episode up to 19 already being fully downloaded. one time it even timed out again at an episode that was already fully downloaded... which shouldn't be possible.
so yea it'd be a nice optimization if it were to quickly skip already downloaded files.
speaking of timing out, i propose a new "retry" command line option where you can tell the program how many times it should retry to download a file (and how long to wait before each try) before giving up and exiting with an error.
just a general QoL addition so you can be sure it will try a little harder and not have it start downloading 100 animes, only to come back a few hours later to realize it stopped at episode 2 of the first one because it timed out.
episode selection with the commandline could also use an overhaul. being able to use a file instead of everything having to be in the command is already great, especially since you can specify whole seasons and animes with it.
but if you just want a select few episodes you need to specify the full URL to each of them, which is just... why???
why couldn't it just take the base URL to the anime, for example
"https://aniworld.to/anime/stream/inuyasha"
and then you give it a seperate formatted string to specify a list/range of episodes to download, for example:"S1E1"
would only download season 1 episode 1 of the above specified anime"S2"
would download the entirety of season 2"S1E10-S2E1"
would download every episode between (and including) season 1 episode 10 and season 2 episode 1"S1, S3E10, S3E12"
would download all of season 1, and season 3 episodes 10 and 12obviously parsing such a string takes quite a bit of effort and time to implement, but since it's python i would assume there to be a few dozen libaries for that already, which would help.
really minor detail, but it would be a good addition to have season/episode numbers in the output files extended with 0's.
so for example if you have an anime with 100 episodes in a season (1-100) then all episode numbers in the file names should be 3 digits wide like so:
S1E001, S1E002, ..., S1E015, S1E016, S1E017, ..., S1E100
with the reason being that it makes sure the files are sorted in the correct order on whatever device you want to watch them on. this comes from both myself and a friend of mine, he watches the downloaded stuff on his TV via a USB drive and i watch it via VLC by opening the whole folder with it.
in both cases the episodes get sorted like so:
having leading 0s to make them all the same width would solve this.
.
anyways, besides these things i otherwise cannot really complain about this program. good job dude! and i hope you keep it alive
The text was updated successfully, but these errors were encountered: