Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warning: control reaches end of non-void function #11

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

remicollet
Copy link
Contributor

libtool: compile:  cc -I. -I/work/GIT/pecl-and-ext/ecma_intl -I/work/GIT/pecl-and-ext/ecma_intl/include -I/work/GIT/pecl-and-ext/ecma_intl/main -I/work/GIT/pecl-and-ext/ecma_intl -I/opt/remi/php82/root/usr/include/php -I/opt/remi/php82/root/usr/include/php/main -I/opt/remi/php82/root/usr/include/php/TSRM -I/opt/remi/php82/root/usr/include/php/Zend -I/opt/remi/php82/root/usr/include/php/ext -I/opt/remi/php82/root/usr/include/php/ext/date/lib -I/work/GIT/pecl-and-ext/ecma_intl/src -DHAVE_CONFIG_H -O2 -Wp,-D_FORTIFY_SOURCE=2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -DZEND_COMPILE_DL_EXT=1 -c /work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c -MMD -MF src/php/classes/locale.dep -MT src/php/classes/locale.lo  -fPIC -DPIC -o src/php/classes/.libs/locale.o
/work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c: In function 'weekDayEcmaToIcu':
/work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c:525:1: warning: control reaches end of non-void function [-Wreturn-type]
  525 | }
      | ^
/work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c: In function 'weekDayIcuToEcma':
/work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c:544:1: warning: control reaches end of non-void function [-Wreturn-type]
  544 | }
      | ^
In file included from /work/GIT/pecl-and-ext/ecma_intl/src/php/php_common.h:25,
                 from /work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.h:16,
                 from /work/GIT/pecl-and-ext/ecma_intl/src/php/classes/locale.c:13:

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #11 (e012f7a) into main (a0f108f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          12       12           
  Lines         942      942           
  Branches      182      182           
=======================================
  Hits          775      775           
  Misses         94       94           
  Partials       73       73           
Flag Coverage Δ
unittests 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ramsey
Copy link
Member

ramsey commented Aug 29, 2023

Thank you for contributing! 🎉

@ramsey ramsey merged commit 7143601 into php-ecma-intl:main Aug 29, 2023
12 checks passed
@remicollet remicollet deleted the issue-warns branch August 30, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants