From 00616a63497fd554bccb530015ab3773829d9305 Mon Sep 17 00:00:00 2001
From: Wilmer Arambula <42547589+terabytesoftw@users.noreply.github.com>
Date: Fri, 19 Jan 2024 18:07:51 -0300
Subject: [PATCH] Add type hint convert classes. (#5)

---
 src/Converter/SemverConverter.php           |  6 ++-
 src/Converter/SemverUtil.php                | 46 ++++++++++-----------
 src/Converter/VersionConverterInterface.php |  6 ++-
 3 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/src/Converter/SemverConverter.php b/src/Converter/SemverConverter.php
index adeda1e..3b211af 100644
--- a/src/Converter/SemverConverter.php
+++ b/src/Converter/SemverConverter.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Foxy package.
  *
@@ -16,9 +18,9 @@
  *
  * @author François Pluchino <francois.pluchino@gmail.com>
  */
-class SemverConverter implements VersionConverterInterface
+final class SemverConverter implements VersionConverterInterface
 {
-    public function convertVersion($version)
+    public function convertVersion(string $version = null): string
     {
         if (\in_array($version, array(null, '', 'latest'), true)) {
             return ('latest' === $version ? 'default || ' : '').'*';
diff --git a/src/Converter/SemverUtil.php b/src/Converter/SemverUtil.php
index 1d27d48..1e49a32 100644
--- a/src/Converter/SemverUtil.php
+++ b/src/Converter/SemverUtil.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Foxy package.
  *
@@ -23,11 +25,9 @@ abstract class SemverUtil
     /**
      * Converts the date or datetime version.
      *
-     * @param string $version The version
-     *
-     * @return string
+     * @param string $version The version.
      */
-    public static function convertDateVersion($version)
+    public static function convertDateVersion(string $version): string
     {
         if (preg_match('/^\d{7,}\./', $version)) {
             $pos = strpos($version, '.');
@@ -41,10 +41,8 @@ public static function convertDateVersion($version)
      * Converts the version metadata.
      *
      * @param string $version
-     *
-     * @return string
      */
-    public static function convertVersionMetadata($version)
+    public static function convertVersionMetadata(string $version): string
     {
         if (preg_match_all(
             self::createPattern('([a-zA-Z]+|(\-|\+)[a-zA-Z]+|(\-|\+)[0-9]+)'),
@@ -70,11 +68,11 @@ public static function convertVersionMetadata($version)
     /**
      * Creates a pattern with the version prefix pattern.
      *
-     * @param string $pattern The pattern without '/'
+     * @param string $pattern The pattern without '/'.
      *
-     * @return string The full pattern with '/'
+     * @return string The full pattern with '/'.
      */
-    public static function createPattern($pattern)
+    public static function createPattern(string $pattern): string
     {
         $numVer = '([0-9]+|x|\*)';
         $numVer2 = '('.$numVer.'\.'.$numVer.')';
@@ -86,11 +84,11 @@ public static function createPattern($pattern)
     /**
      * Clean the wildcard in version.
      *
-     * @param string $version The version
+     * @param string $version The version.
      *
-     * @return string The cleaned version
+     * @return string The cleaned version.
      */
-    private static function cleanWildcard($version)
+    private static function cleanWildcard(string $version): string
     {
         while (false !== strpos($version, '.x.x')) {
             $version = str_replace('.x.x', '.x', $version);
@@ -102,12 +100,12 @@ private static function cleanWildcard($version)
     /**
      * Clean the raw version.
      *
-     * @param string $version The version
-     * @param array  $matches The match of pattern asset version
+     * @param string $version The version.
+     * @param array $matches The match of pattern asset version.
      *
-     * @return array The list of $type, $version and $end
+     * @return array The list of $type, $version and $end.
      */
-    private static function cleanVersion($version, array $matches)
+    private static function cleanVersion(string $version, array $matches): array
     {
         $end = substr($version, \strlen($matches[1][0][0]));
         $version = $matches[1][0][0].'-';
@@ -128,12 +126,12 @@ private static function cleanVersion($version, array $matches)
     /**
      * Match the version.
      *
-     * @param string $version
-     * @param string $type
+     * @param string $version The version.
+     * @param string $type The type of version.
      *
-     * @return array The list of $version and $patchVersion
+     * @return array The list of $version and $patchVersion.
      */
-    private static function matchVersion($version, $type)
+    private static function matchVersion(string $version, string $type): array
     {
         $patchVersion = true;
 
@@ -172,11 +170,9 @@ private static function matchVersion($version, $type)
     /**
      * Convert the minor version of date.
      *
-     * @param string $minor The minor version
-     *
-     * @return string
+     * @param string $minor The minor version.
      */
-    private static function convertDateMinorVersion($minor)
+    private static function convertDateMinorVersion(string $minor): string
     {
         $split = explode('.', $minor);
         $minor = (int) $split[0];
diff --git a/src/Converter/VersionConverterInterface.php b/src/Converter/VersionConverterInterface.php
index afa48d4..4c19bba 100644
--- a/src/Converter/VersionConverterInterface.php
+++ b/src/Converter/VersionConverterInterface.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Foxy package.
  *
@@ -21,9 +23,9 @@ interface VersionConverterInterface
     /**
      * Converts the asset version to composer version.
      *
-     * @param string $version The asset version
+     * @param string|null $version The asset version
      *
      * @return string The composer version
      */
-    public function convertVersion($version);
+    public function convertVersion(string $version = null): string;
 }