Psalm 3. (#18)

psalm.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <psalm
-  errorLevel="4"
+  errorLevel="3"
   findUnusedBaselineEntry="true"
   findUnusedCode="false"
   resolveFromConfigFile="true"

src/Asset/AbstractAssetManager.php

@@ -35,7 +35,6 @@ abstract class AbstractAssetManager implements AssetManagerInterface
 {
     final public const NODE_MODULES_PATH = './node_modules';
     protected bool $updatable = true;
-    protected VersionConverterInterface|null $versionConverter;
     private null|string $version = '';
 
     public function __construct(
@@ -44,9 +43,9 @@ public function __construct(
         protected ProcessExecutor $executor,
         protected Filesystem $fs,
         protected FallbackInterface|null $fallback = null,
-        VersionConverterInterface|null $versionConverter = null
+        protected VersionConverterInterface|null $versionConverter = null
     ) {
-        $this->versionConverter = $versionConverter ?? new SemverConverter();
+        $this->versionConverter ??= new SemverConverter();
     }
 
     public function isAvailable(): bool
@@ -107,7 +106,14 @@ public function validate(): void
             $constraint = $parser->parseConstraints($constraintVersion);
 
             if (!$constraint->matches($parser->parseConstraints($version))) {
-                throw new RuntimeException(sprintf('The installed %s version "%s" doesn\'t match with the constraint version "%s"', $this->getName(), $version, $constraintVersion));
+                throw new RuntimeException(
+                    sprintf(
+                        'The installed %s version "%s" doesn\'t match with the constraint version "%s"',
+                        $this->getName(),
+                        $version,
+                        $constraintVersion
+                    )
+                );
             }
         }
     }
@@ -182,7 +188,7 @@ protected function buildCommand(string $defaultBin, string $action, array|string
 
     protected function getVersion(): string|null
     {
-        if ('' === $this->version) {
+        if ($this->version === '' && $this->versionConverter !== null) {
             $this->executor->execute($this->getVersionCommand(), $version);
             $this->version = '' !== trim((string) $version) ? $this->versionConverter->convertVersion(trim((string) $version)) : null;
         }

src/Asset/AssetPackage.php

@@ -79,6 +79,15 @@ public function getInstalledDependencies(): array
         return $installedAssets;
     }
 
+    /**
+     * Add new dependencies.
+     *
+     * @param array $dependencies The dependencies
+     *
+     * @return array The existing packages.
+     *
+     * @psalm-return list<string> The existing packages.
+     */
     public function addNewDependencies(array $dependencies): array
     {
         $installedAssets = $this->getInstalledDependencies();

src/Asset/YarnManager.php

@@ -71,7 +71,7 @@ private function isYarnNext(): bool
         $parser = new VersionParser();
         $constraint = $parser->parseConstraints('>=2.0.0');
 
-        return $constraint->matches($parser->parseConstraints($version));
+        return $version !== null ? $constraint->matches($parser->parseConstraints($version)) : false;
     }
 
     private function mergeInteractiveCommand(array $command): array

src/Converter/SemverUtil.php

@@ -31,7 +31,10 @@ public static function convertDateVersion(string $version): string
     {
         if (preg_match('/^\d{7,}\./', $version)) {
             $pos = strpos($version, '.');
-            $version = substr($version, 0, $pos) . self::convertDateMinorVersion(substr($version, $pos + 1));
+
+            if ($pos !== false) {
+                $version = substr($version, 0, $pos) . self::convertDateMinorVersion(substr($version, $pos + 1));
+            }
         }
 
         return $version;
@@ -42,12 +45,13 @@ public static function convertDateVersion(string $version): string
      */
     public static function convertVersionMetadata(string $version): string
     {
-        if (preg_match_all(
-            self::createPattern('([a-zA-Z]+|(\-|\+)[a-zA-Z]+|(\-|\+)[0-9]+)'),
-            $version,
-            $matches,
-            PREG_OFFSET_CAPTURE
-        )) {
+        $pattern = self::createPattern('([a-zA-Z]+|(\-|\+)[a-zA-Z]+|(\-|\+)[0-9]+)');
+
+        if ($pattern === '') {
+            return $version;
+        }
+
+        if (preg_match_all($pattern, $version, $matches, PREG_OFFSET_CAPTURE)) {
             [$type, $version, $end] = self::cleanVersion(strtolower($version), $matches);
             [$version, $patchVersion] = self::matchVersion($version, $type);
 

src/Foxy.php

@@ -77,6 +77,8 @@ final class Foxy implements PluginInterface, EventSubscriberInterface
 
     /**
      * The list of the classes of asset managers.
+     *
+     * @psalm-var list<class-string<AssetManagerInterface>>
      */
     private static $assetManagers = [
         Asset\NpmManager::class,