create Application layer

composer.json

@@ -44,6 +44,8 @@
             "@csfix",
             "@test-all"
         ],
+        "fix": "@csfix",
+        "test": "@test-all",
         "test-all": [
             "@quality",
             "@phpunit"

src/Invoice/Domain/CallbackUrl/CallbackUrl.php → src/Invoice/Application/CallbackUrl.php

@@ -2,8 +2,10 @@
 
 declare(strict_types=1);
 
-namespace PhpLightning\Invoice\Domain\CallbackUrl;
+namespace PhpLightning\Invoice\Application;
 
+use PhpLightning\Invoice\Domain\CallbackUrl\CallbackUrlInterface;
+use PhpLightning\Invoice\Domain\CallbackUrl\LnAddressGeneratorInterface;
 use PhpLightning\Shared\Value\SendableRange;
 
 final class CallbackUrl implements CallbackUrlInterface

src/Invoice/Domain/LnAddress/InvoiceGenerator.php → src/Invoice/Application/InvoiceGenerator.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace PhpLightning\Invoice\Domain\LnAddress;
+namespace PhpLightning\Invoice\Application;
 
 use PhpLightning\Invoice\Domain\BackendInvoice\BackendInvoiceInterface;
 use PhpLightning\Shared\Transfer\BackendInvoiceResponse;

src/Invoice/Domain/CallbackUrl/LnAddressGenerator.php

@@ -14,7 +14,7 @@ public function __construct(
 
     public function generate(?string $username): string
     {
-        if (empty($username)) {
+        if ($username === null || $username === '') {
             return $this->defaultLnAddress;
         }
 

src/Invoice/InvoiceFactory.php

@@ -5,14 +5,14 @@
 namespace PhpLightning\Invoice;
 
 use Gacela\Framework\AbstractFactory;
+use PhpLightning\Invoice\Application\CallbackUrl;
+use PhpLightning\Invoice\Application\InvoiceGenerator;
 use PhpLightning\Invoice\Domain\BackendInvoice\BackendInvoiceInterface;
 use PhpLightning\Invoice\Domain\BackendInvoice\LnbitsBackendInvoice;
-use PhpLightning\Invoice\Domain\CallbackUrl\CallbackUrl;
 use PhpLightning\Invoice\Domain\CallbackUrl\CallbackUrlInterface;
 use PhpLightning\Invoice\Domain\CallbackUrl\LnAddressGenerator;
 use PhpLightning\Invoice\Domain\CallbackUrl\LnAddressGeneratorInterface;
 use PhpLightning\Invoice\Domain\Http\HttpApiInterface;
-use PhpLightning\Invoice\Domain\LnAddress\InvoiceGenerator;
 
 /**
  * @method InvoiceConfig getConfig()

src/Shared/Transfer/BackendInvoiceResponse.php

@@ -7,10 +7,17 @@
 final class BackendInvoiceResponse
 {
     private string $status = 'OK';
+
     private string $paymentRequest = '';
+
+    /** @var list<string> */
     private array $successAction = [];
+
+    /** @var list<string> */
     private array $routes = [];
+
     private bool $disposable = false;
+
     private string $reason = '';
 
     public function getPaymentRequest(): string
@@ -35,22 +42,34 @@ public function setStatus(string $status): self
         return $this;
     }
 
+    /**
+     * @return list<string>
+     */
     public function getSuccessAction(): array
     {
         return $this->successAction;
     }
 
+    /**
+     * @param list<string> $successAction
+     */
     public function setSuccessAction(array $successAction): self
     {
         $this->successAction = $successAction;
         return $this;
     }
 
+    /**
+     * @return list<string>
+     */
     public function getRoutes(): array
     {
         return $this->routes;
     }
 
+    /**
+     * @param list<string> $routes
+     */
     public function setRoutes(array $routes): self
     {
         $this->routes = $routes;

tests/Unit/Invoice/Domain/CallbackUrl/CallbackUrlTest.php

@@ -4,8 +4,8 @@
 
 namespace PhpLightningTest\Unit\Invoice\Domain\CallbackUrl;
 
+use PhpLightning\Invoice\Application\CallbackUrl;
 use PhpLightning\Invoice\Domain\BackendInvoice\BackendInvoiceInterface;
-use PhpLightning\Invoice\Domain\CallbackUrl\CallbackUrl;
 use PhpLightning\Invoice\Domain\CallbackUrl\LnAddressGeneratorInterface;
 use PhpLightning\Shared\Transfer\BackendInvoiceResponse;
 use PhpLightning\Shared\Value\SendableRange;

tests/Unit/Invoice/Domain/LnAddress/InvoiceGeneratorTest.php

@@ -4,8 +4,8 @@
 
 namespace PhpLightningTest\Unit\Invoice\Domain\LnAddress;
 
+use PhpLightning\Invoice\Application\InvoiceGenerator;
 use PhpLightning\Invoice\Domain\BackendInvoice\BackendInvoiceInterface;
-use PhpLightning\Invoice\Domain\LnAddress\InvoiceGenerator;
 use PhpLightning\Shared\Transfer\BackendInvoiceResponse;
 use PhpLightning\Shared\Value\SendableRange;
 use PHPUnit\Framework\TestCase;