refactor: rename supports methods (#13)

* Rename method * refactor: supports method names --------- Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
php-llm · Sep 22, 2024 · 9668be9 · 9668be9
1 parent d67c5e7
commit 9668be9
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/Anthropic/Model/Claude.php b/src/Anthropic/Model/Claude.php
@@ -37,12 +37,12 @@ public function call(MessageBag $messages, array $options = []): Response
         return new Response(new Choice($response['content'][0]['text']));
     }
 
-    public function hasToolSupport(): bool
+    public function supportsToolCalling(): bool
     {
         return false; // it does, but implementation here is still open.
     }
 
-    public function hasStructuredOutputSupport(): bool
+    public function supportsStructuredOutput(): bool
     {
         return false;
     }

diff --git a/src/Chain.php b/src/Chain.php
@@ -27,11 +27,11 @@ public function call(MessageBag $messages, array $options = []): string|object
     {
         $llmOptions = $options;
 
-        if (!array_key_exists('tools', $llmOptions) && null !== $this->toolRegistry && $this->llm->hasToolSupport()) {
+        if (!array_key_exists('tools', $llmOptions) && null !== $this->toolRegistry && $this->llm->supportsToolCalling()) {
             $llmOptions['tools'] = $this->toolRegistry->getMap();
         }
 
-        if (array_key_exists('output_structure', $llmOptions) && null !== $this->responseFormatFactory && $this->llm->hasStructuredOutputSupport()) {
+        if (array_key_exists('output_structure', $llmOptions) && null !== $this->responseFormatFactory && $this->llm->supportsStructuredOutput()) {
             $llmOptions['response_format'] = $this->responseFormatFactory->create($llmOptions['output_structure']);
             unset($llmOptions['output_structure']);
         }

diff --git a/src/LanguageModel.php b/src/LanguageModel.php
@@ -14,7 +14,7 @@ interface LanguageModel
      */
     public function call(MessageBag $messages, array $options = []): Response;
 
-    public function hasToolSupport(): bool;
+    public function supportsToolCalling(): bool;
 
-    public function hasStructuredOutputSupport(): bool;
+    public function supportsStructuredOutput(): bool;
 }
diff --git a/src/OpenAI/Model/Gpt.php b/src/OpenAI/Model/Gpt.php
@@ -34,14 +34,14 @@ public function call(MessageBag $messages, array $options = []): Response
         return new Response(...array_map([$this, 'convertChoice'], $response['choices']));
     }
 
-    public function hasToolSupport(): bool
+    public function supportsToolCalling(): bool
     {
         return true;
     }
 
-    public function hasStructuredOutputSupport(): bool
+    public function supportsStructuredOutput(): bool
     {
-        return $this->version->hasStructuredOutputSupport();
+        return $this->version->supportsStructuredOutput();
     }
 
     /**

diff --git a/src/OpenAI/Model/Gpt/Version.php b/src/OpenAI/Model/Gpt/Version.php
@@ -13,7 +13,7 @@ enum Version: string
     case GPT_4o = 'gpt-4o';
     case GPT_4o_MINI = 'gpt-4o-mini';
 
-    public function hasStructuredOutputSupport(): bool
+    public function supportsStructuredOutput(): bool
     {
         return self::GPT_4o === $this || self::GPT_4o_MINI === $this;
     }