small correction in regex

phpDocumentor · Aug 16, 2015 · abe889a · abe889a
1 parent 0a99d5b
commit abe889a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Specification/InPath.php b/src/Specification/InPath.php
@@ -49,7 +49,7 @@ public function isSatisfiedBy(array $value)
             $validChars = '[a-zA-Z0-9\\\/\.\<\>\,\|\:\(\)\&\;\#]';
 
             $pattern = '(^(?!\/)'
-                . str_replace(['?', '*'], [$validChars . '?', $validChars . '*'], $path)
+                . str_replace(['?', '*'], [$validChars . '{1}', $validChars . '*'], $path)
                 . $validChars . '*)';
 
             if (preg_match($pattern, $value['dirname'] . '/')) {

diff --git a/tests/unit/Specification/InPathTest.php b/tests/unit/Specification/InPathTest.php
@@ -55,15 +55,16 @@ public function validDirnames()
             ['.hiddendir/n'],
             ['.hiddendir/n/'],
             ['.hiddendir/n/somedir'],
-            ['.hiddendir/n/somedir.txt']
+            ['.hiddendir/n/somedir.txt'],
+            ['ddenxir/n']
         ];
     }
 
     /**
      * @covers ::__construct
      * @covers ::isSatisfiedBy
      * @covers ::<private>
-     * @dataProvider InvalidDirnames
+     * @dataProvider invalidDirnames
      * @uses Flyfinder\Path
      */
     public function testIfSpecificationIsNotSatisfied($dirname)
@@ -76,12 +77,14 @@ public function testIfSpecificationIsNotSatisfied($dirname)
      *
      * @return array
      */
-    public function InvalidDirnames()
+    public function invalidDirnames()
     {
         return [
             ['/hiddendir/n'],
             ['.hiddendir/normaldir'],
-            ['.hiddendir.ext/n']
+            ['.hiddendir.ext/n'],
+            ['.hiddenxxir/n'],
+            ['.hiddenir/n']
         ];
     }
 }