Skip to content

Commit

Permalink
PHP 8.3
Browse files Browse the repository at this point in the history
  • Loading branch information
phpfui committed Nov 23, 2023
1 parent db3bc58 commit 3e19c39
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.2, 8.1, 8.0]
php: [8.3, 8.2, 8.1, 8.0]
dependency-version: [prefer-stable]
os: [ubuntu-latest]

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}
],
"require": {
"php": ">=8.0 <8.3",
"php": ">=8.0 <8.4",
"phpfui/phpfui": "^6.0",
"phpdocumentor/reflection-docblock": "^5.0",
"gitonomy/gitlib": "^1.2",
Expand Down
3 changes: 3 additions & 0 deletions src/PHPFUI/InstaDoc/Section/CodeCommon.php
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ protected function formatComments(?\phpDocumentor\Reflection\DocBlock $docBlock,
}

$tags = $docBlock->getTags();

// if we are in a method, inheritdoc makes sense, and we should get the correct doc block comments
if ($reflection instanceof \ReflectionMethod)
{
Expand All @@ -230,6 +231,7 @@ protected function formatComments(?\phpDocumentor\Reflection\DocBlock $docBlock,
$name = $tag->getName();
$description = \method_exists($tag, 'getDescription') ? \trim($tag->getDescription() ?? '') : '';
$body = '';

// punt on useless tags
if (\in_array($name, ['method', 'inheritdoc']))
{
Expand Down Expand Up @@ -403,6 +405,7 @@ protected function getClassName(string | object $class, bool $asLink = true) : s
$array = '[]';
$class = \str_replace($array, '', $class);
}

// if fully qualified, we are done
if (\PHPFUI\InstaDoc\NamespaceTree::hasClass($class))
{
Expand Down
2 changes: 0 additions & 2 deletions src/PHPFUI/InstaDoc/Tests/Status.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
enum Status
{
case Archived;

case Draft;

case Published;
}

0 comments on commit 3e19c39

Please sign in to comment.