add float type to integerish assertion

phpstan · Jan 31, 2021 · 1657403 · 1657403
1 parent 2873b44
commit 1657403
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/src/Type/WebMozartAssert/AssertTypeSpecifyingExtension.php b/src/Type/WebMozartAssert/AssertTypeSpecifyingExtension.php
@@ -202,21 +202,9 @@ private static function getExpressionResolvers(): array
 					);
 				},
 				'integerish' => function (Scope $scope, Arg $value): \PhpParser\Node\Expr {
-					return new \PhpParser\Node\Expr\BinaryOp\BooleanOr(
-						new \PhpParser\Node\Expr\BinaryOp\BooleanAnd(
-							new \PhpParser\Node\Expr\FuncCall(
-								new \PhpParser\Node\Name('is_string'),
-								[$value]
-							),
-							new \PhpParser\Node\Expr\FuncCall(
-								new \PhpParser\Node\Name('is_numeric'),
-								[$value]
-							)
-						),
-						new \PhpParser\Node\Expr\FuncCall(
-							new \PhpParser\Node\Name('is_int'),
-							[$value]
-						)
+					return new \PhpParser\Node\Expr\FuncCall(
+						new \PhpParser\Node\Name('is_numeric'),
+						[$value]
 					);
 				},
 				'numeric' => function (Scope $scope, Arg $value): \PhpParser\Node\Expr {

diff --git a/tests/Type/WebMozartAssert/AssertTypeSpecifyingExtensionTest.php b/tests/Type/WebMozartAssert/AssertTypeSpecifyingExtensionTest.php
@@ -153,7 +153,7 @@ public function testExtension(): void
 				116,
 			],
 			[
-				'Variable $ad is: int|(string&numeric)',
+				'Variable $ad is: float|int|(string&numeric)',
 				119,
 			],
 			[
-Original file line number
+Diff line change
@@ Expand Up / @@ -153,7 +153,7 @@ public function testExtension(): void @@
 ,
     			],
     			[
-    				'Variable $ad is: int|(string&numeric)',
+    				'Variable $ad is: float|int|(string&numeric)',
 ,
     			],
     			[
@@ Expand Down @@