-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good first issues #5
Comments
I want to contribute, what exactly I've to do? |
I think the best way to get started is contributing to the way in which warnings are raised. gender*render uses a system (gender_render.warnings) to show warnings and allow fine-grained customization of which warnings are shown and which are not. This does, however, come with the downside that warnings are always shows with the file name " This is also documented in the 2nd If you make a pull request for this, you'd also need to agree that the contents of said pull request are licensed together with the rest of the gender*render implementation under the MIT license; I plan to add a CLA assistent for that to the repository, so that's merely a formality. Contributions to gender_render source code should follow PEP8 convention. Please feel free to ask additional questions or ask for clarification on my explanation, and thank you for your interest in contributing! |
I want to contribute, can u just tell me what to do exactly? |
Hello, and thank you for your interest in contributing! @Gauravkain it somewhat depends on whether Kushagrabainsla is still interested in contributing.... If they are not, I would suggest you to tackle the issue I had for Kushagrabainsla, and if they are still interested in contributing, I will find something else for you to work on and give you detailed instructions on what you can do. I hope you don't mind if we wait for them to answer... @Kushagrabainsla are you still interested in contributing? If not, I would assign the issue I had for you to Gauravkain. But no need to rush yourself; if you don't have time to work on it for now, but still intend to work on it in the future, I will find something else for them to work on. |
I've removed the @Kushagrabainsla I'd greatly appreciate it if you could give me a short reply on whether you still want to contribute, so that I know whether I can expect a pull request sometime or whether I can assign the issue to Gauravkain/ tackle it myself. |
@phseiff, Right now I'm working on something else, so you should assign this issue to @Gauravkain. |
@Gauravkain You can create a pull request for this issue, if you want to. I can also open a separate GitHub issue specifically for this, which I can then explicitely assign to you if you comment on it, in case you'd like that. After you've created your pull request, I'll review the changes you made and potentially ask for some adjustments to be made (but I can also do them myself in case you run our of time) and then merge it. |
Hey @phseiff. I want to contribute to this issue. I will be working continuously on it once it is assigned to me. |
There are some details in the implementation that are less-than-ideal, not connected to any of the other bigger issues I already created for this repository, and relatively separated from specification content and bigger concepts.
These issues are mostly marked as "ToDo" in the implementation (note that not every issue marked as ToDo is necessarily one of them). If you want, you can work on one of them and create a pull request (especially those regarding the warning system), but please raise an issue before you do to discuss the way you go about the implementation, so we can make sure it doesn't get into the way of vague design decisions that need to be upheld for later features.
The text was updated successfully, but these errors were encountered: