Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy citation button #162

Closed
StevenClontz opened this issue Jul 11, 2024 · 5 comments
Closed

Fix copy citation button #162

StevenClontz opened this issue Jul 11, 2024 · 5 comments
Assignees

Comments

@StevenClontz
Copy link
Member

No description provided.

@StevenClontz
Copy link
Member Author

In addition to the fix at #164, we have another issue. When visiting https://topology.pi-base.org/spaces one can edit the search parameters, and it appears to update the citation for that page. However, those updates aren't reflected in the copied text from the Markdown button. We should fix this.

@StevenClontz
Copy link
Member Author

I believe #157 has a hint on what we might need to do (use #key to force the component to rerender given new values for the text to be copied).

@prabau
Copy link

prabau commented Sep 19, 2024

Has #164 done anything? It used to be that the Copy: Markdown link button on the Explore page would copy something that would display the current search. But that behavior became broken at some point. And that it still broken, even with #164. What we get is just:

[π-Base, Explore](https://topology.pi-base.org/spaces)

@StevenClontz
Copy link
Member Author

I think it fixed the front page button, but there's still work to do on the explore page.

@StevenClontz
Copy link
Member Author

Closed by #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants