Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display aliases on Explore page #177

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Conversation

StevenClontz
Copy link
Member

Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2024

Deploying topology with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d0ec89
Status: ✅  Deploy successful!
Preview URL: https://42dcb839.topology.pages.dev
Branch Preview URL: https://stevenclontz-explore-aliases.topology.pages.dev

View logs

@StevenClontz
Copy link
Member Author

@prabau thoughts?

@StevenClontz
Copy link
Member Author

image

@StevenClontz
Copy link
Member Author

The fact "cantor space" doesn't show up first for "cantor" is addressed here: #178

@prabau
Copy link

prabau commented Oct 11, 2024

The search filtering both by formula and by text does not work as expected. When searching for compact spaces related to "Cantor", one get things like S19, S20, which are compact but have nothing to do with "Cantor", even with fuzzy matching. It seems that there is a flaw in the algorithm here.

Even searching for "cantor" without specifying properties returns spaces like Euclidean real numbers, Irrational numbers, Altered long ray, etc that have nothing to do with "cantor", 43 spaces in total.

Ordering the results by closest match when searching by text does not seem a bad idea, but the problem above is much more serious and should be looked at.

Compare also with the search from the Spaces page:
https://topology.pi-base.org/spaces/all?filter=cantor
which gives the first best three matches in the right order, followed by irrelevant ones.

@prabau
Copy link

prabau commented Oct 11, 2024

As for displaying the alias for spaces, would that apply only when filtering by text (with or without also filtering by formula)?
When not filtering by text, it's maybe preferable not to use it because it occupies more real estate and there is no need to. When filtering by text, it could be ok.

Another thing that the sample screenshot above points to is the inadequacy of many of the current aliases.
Just taking S36 (Successor to the first uncountable ordinal) as an example, we have aliases like "Omega1 + 1" and "ω_1 + 1" and ... Several of these aliases date from way back, when we could not render LaTex in aliases. But that has changed. Some of the other aliases may also be debatable.

I think it would be beneficial to discuss in general terms how to improve the aliases, and also the search issue above. A good topic for next zoom meeting.

@StevenClontz
Copy link
Member Author

When not filtering by text, it's maybe preferable not to use it because it occupies more real estate and there is no need to.

I thought about this, but I still think that if we have relegated the name of a space to an alias that a user expects, it's still good to have it handy so they can quickly find a space they are familiar with, even if we use a different canonical name than they are used to.

inadequacy of many of the current aliases

Absolutely agreed - if we're going to display aliases this prominantly, we should also clean up some less-useful ones. I like discussing this next month.

@prabau
Copy link

prabau commented Oct 11, 2024

I thought about this, but I still think that if we have relegated the name of a space to an alias that a user expects, it's still good to have it handy so they can quickly find a space they are familiar with, even if we use a different canonical name than they are used to.

Maybe. Although when you filter only by formula, you are interested in just a list of spaces matching the criteria. Then the user can just click on things that look interesting and they will find more detail of each space if they want to. It does not matter that the name is not the one they are used to. After drilling down, they will find more details. Anyway, we can discuss further in the zoom meeting.

@GeoffreySangston
Copy link

GeoffreySangston commented Nov 1, 2024

Is there a way that the 'Filter by formula' drop down can indicate when a property is appearing because it almost matches one of the aliases? The word 'Alias' could appear in the bottom right of the box, or the box could be colored light green. Or perhaps better, instead of displaying the name in the 'Filter by formula' drop down box, it could just display the matching alias.

(Funnily enough, I briefly couldn't find limit point compact yesterday because the name is now weakly countably compact, and I just saw this was also discussed recently.)

Edit: Another situation when it would be better to display the alias is when an algebraic geometer searches for 'irreducible' and doesn't see it in the dropdown list, because it is named 'hyperconnected'.

@StevenClontz
Copy link
Member Author

Adding aliases to the formula suggestion box might be the simplest solution here:

image

@prabau
Copy link

prabau commented Nov 1, 2024

@GeoffreySangston @StevenClontz While is was true that the aliases were not displayed in the search box, they were looked at as part of the search. We should discuss more today in the zoom meeting.

@StevenClontz
Copy link
Member Author

Thanks everyone for your feedback in today's community call. I'm deploying to production now; let me know your feedback and we can iterate from here.

@StevenClontz StevenClontz merged commit 49fd2f9 into main Nov 1, 2024
3 checks passed
@StevenClontz StevenClontz deleted the StevenClontz/explore-aliases branch November 1, 2024 21:35
@prabau
Copy link

prabau commented Nov 2, 2024

This is a nice improvement. The adjustment of the threshold for searching by space name/alias in the Explore page really helped narrow down the result as desired.

Next step: make the corresponding adjustment for the search box in the Spaces page.

@GeoffreySangston
Copy link

I guess this might be a good place to mention this.

On the properties page, cmd + F shows are 6 properties which just give "Any of the following equivalent properties holds:", followed by a block of equivalent definitions. I think we should move the top line of each block to the top.

@prabau
Copy link

prabau commented Nov 4, 2024

I guess this might be a good place to mention this.

On the properties page, cmd + F shows are 6 properties which just give "Any of the following equivalent properties holds:", followed by a block of equivalent definitions. I think we should move the top line of each block to the top.

I think the most important thing is to have a clear and coherent text on each property page. What is displayed in the Properties list is not very important. So I may not agree with this. Can we make this an item of discussion for the next community meeting?

@StevenClontz
Copy link
Member Author

I actually lean towards @GeoffreySangston's suggestion that having one common characterization in the top line would be nice to show up in previews, and we can also include it in a list of equivalent characterziations in a fuller description (so it's not missed there either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants