-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve EDNS handling #2062
Improve EDNS handling #2062
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
…enting this Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need amendments to the docs for the new database query status QUERY_EXTERNAL_BLOCKED_EDE15
?
Do we need to change the web interface to show this new value? |
@rdwebdesign No, in v6, we query FTL for the defined types and, hence, no web code changes are necessary if new types are added. |
Cool! |
What does this implement/fix?
This PR merges a few EDNS related changes:
Add downstream EDE info for synthesized replies
This commit enriches downstream DNS replies with blocking information. This can be controlled (and also disabled) via the new setting
dns.blocking.edns
.Example:
Add EDE 15 from upstream => Blocked detection
Pi-hole already detects NXRA (NXDOMAIN without RA bit from Quad9 or
unbound
with optionrpz-signal-nxdomain-ra
), NULL address (0.0.0.0
/::
) and a set of known IP addresses (Cisco Umbrella) to determine a query was blocked upstream. This PR adds a new detection that is a query hasEDE 15 = Blocked
set by the upstream resolver. This can be seen, e.g. in routeDNS which is used by the user requesting this feature.Unify query and cache status enums
This is mostly a code maintenance commit without any externally visible changes. It removes the
enum domain_client_status
in favor of the more genericenum query_status
.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): pi-hole/docs#1094
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.