Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Some more detailed Docker documentation #1102

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Add Some more detailed Docker documentation #1102

merged 1 commit into from
Oct 2, 2024

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

WIP: Probably needs some polish and proof reading!

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team September 25, 2024 22:52
rdwebdesign
rdwebdesign requested changes Sep 26, 2024
View reviewed changes
docs/docker/configuration.md Outdated Show resolved Hide resolved
@PromoFaux PromoFaux changed the base branch from navigation.indexes to release/v6.0 September 26, 2024 12:12
@PromoFaux PromoFaux closed this Sep 26, 2024
@PromoFaux PromoFaux reopened this Sep 26, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 3053c45
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/66f6a1f1089fac0008b66a9c
😎 Deploy Preview https://deploy-preview-1102--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rdwebdesign
rdwebdesign requested changes Sep 26, 2024
View reviewed changes
docs/docker/upgrading/v5-v6.md Outdated Show resolved Hide resolved
@yubiuser
Copy link
Member

I think this needs a rebase, or? Most of the commits were also part of your other PR.

@PromoFaux PromoFaux changed the base branch from release/v6.0 to master September 26, 2024 19:40
@PromoFaux PromoFaux changed the base branch from master to release/v6.0 September 26, 2024 19:40
rdwebdesign
rdwebdesign requested changes Sep 26, 2024
View reviewed changes
docs/docker/upgrading/index.md Outdated Show resolved Hide resolved
rdwebdesign
rdwebdesign requested changes Sep 26, 2024
View reviewed changes
docs/docker/index.md Outdated Show resolved Hide resolved
@PromoFaux
Flesh out the Docker section, add some more detailed information abou…
3053c45 
…t configuration and upgrading (with dedicated section about upgrading from V5)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux merged commit 9e728be into release/v6.0 Oct 2, 2024
10 checks passed
@PromoFaux PromoFaux deleted the new/docker branch October 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

@yubiuser yubiuser Awaiting requested review from yubiuser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PromoFaux @yubiuser @rdwebdesign