-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add router nokia-g240wb #791
Add router nokia-g240wb #791
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission. Before reviewing your PR in detail, could you please crop/compress+crop your images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at your screenshots, your DHCP pool ranges from .50
- .250
. However, your Pi's static address .100
is within the pool. Your router won't know this address is already taken and can hand out this address to some other device.
It's better to give devices static addresses outside of the DHCP pool to avoid this conflict. You should set your Pi's address to something <.50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Now the screenshots don't fit the new IP of 192.168.1.10
anymore.
Updated the pics, thanks for the feedback:) |
@yubiuser You reviewed this before, do you still have any objections? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
7d78156
to
82d27af
Compare
Conflicts have been resolved. |
@yubiuser I addressed the comments, PR is ready to be reviewed or merged. Do you mind taking a look to it? Thanks in advance. |
@yubiuser thanks for the review, the guide now has the latest suggestion. |
@yubiuser I addressed the last moments, this time the text should be better. Let me know if you want me to do another update to the Readme file. |
Hi @yubiuser thanks for the latest comments, I didn't notice the typo. The duplicate entry, I noticed the same but I was unsure if remove or not since it was chained to our previous conversations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As (hopefully) last remark: I would re-order the structure of "Grab your IPv4 and IPv6 address from your Raspberry Pi"
And please squash down all your commits into a singel one.
0c693dc
to
c3f2465
Compare
Signed-off-by: Daniel Carvallo <elulcao@icloud.com>
02e789a
to
3eb3077
Compare
Hello @yubiuser, hope your doing good! |
Signed-off-by: Daniel Carvallo <elulcao@icloud.com>
Added Router Nokia G-240W-B guide
Added Router Nokia G-240W-B guide for IPv4 and IPv6 addresses
Added docs/routers/nokia-G240WB.md
By submitting this pull request, I confirm the following:
git rebase
)