Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to 20 #947

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Update Node to 20 #947

merged 2 commits into from
Nov 3, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 29, 2023

What does this PR aim to accomplish?:

Update Node to 20 nd Netlify's Python to 3.11 (as set in ´runtime.txt)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Member Author

Ok netlify stuck on Focal with their build image which only allows up to python 3.8.

https://github.com/netlify/build-image/blob/focal/included_software.md#languages

Their repo is archived now... maybe we need to switch at some point.
https://github.com/netlify/build-image#archive-note

@yubiuser
Copy link
Member Author

Will PF the netlify changes

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Update Node to 20 and Netlify's Python to 3.11 Update Node to 20 Oct 29, 2023
@yubiuser yubiuser requested a review from a team October 29, 2023 19:52
@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit edeb780
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/653eb8ba7a555000073f7ac7
😎 Deploy Preview https://deploy-preview-947--pihole-docs.netlify.app/routers/ubiquiti-usg
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yubiuser yubiuser mentioned this pull request Oct 29, 2023
1 task
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 29, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux PromoFaux merged commit 1529c54 into release/v6.0 Nov 3, 2023
10 checks passed
@PromoFaux PromoFaux deleted the update/dev branch November 3, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pi-hole v6.0 PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants