-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFA #405
MFA #405
Conversation
@dantownsend I tried your changes and they are great, I really like them. Everything works and I really like your solution for the login form. |
@sinisaos Thanks! I think it's almost there now. |
I'm going to release this. There are some things which need improving - I added issues to cover these. I'll try it out in some of my apps. Thanks again both for all the input. 🙇♂️ |
@dantownsend I don't know if that's a good idea, but can you add |
@sinisaos Yeah, I can see that being annoying. The documentation needs to be quite a bit better too - will try and do that later today. |
Related to piccolo-orm/piccolo_api#292
The workflow for MFA is pretty complex, so rather than reimplementing all of the UI in Vue, we'll just mount the MFA endpoint, and send the user there.
So the only bit of Vue code which needs changing is the login form, which needs to render an MFA code input.