Oris/fix ctx #1
Merged
Oris/fix ctx #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ori-shalom
force-pushed
the
oris/fix-ctx
branch
from
cfac1ea to
b0f3ead
Compare
ori-shalom
force-pushed
the
oris/fix-ctx
branch
from
b0f3ead to
bae9ba9
Compare
nirhaas
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update our fork of goose and 2 small fixes.
The steps I took:
pressly/goose.pressly/goosetopiiano/goose.Fix issue where the new Provider option doesn't allow setting directory for the migrations embedded file system.Reverted - actually not needed.
Can be reviewed commit by commit