Fix setting form values; fix user tags check; set default tag's view_…

…order to 1
pijng · Mar 17, 2024 · 7aaa574 · 7aaa574
1 parent c71c29b
commit 7aaa574
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 7 deletions.
diff --git a/internal/api/swagger.yaml b/internal/api/swagger.yaml
@@ -9,7 +9,7 @@ info:
   license:
     name: Apache 2.0
     url: http://www.apache.org/licenses/LICENSE-2.0.html
-  version: 1.6.2
+  version: 1.6.3
 externalDocs:
   description: Find out more about spec
   url: ''

diff --git a/internal/usecases/schema_usecase.go b/internal/usecases/schema_usecase.go
@@ -102,6 +102,10 @@ func (uc *SchemaUseCase) GetAllSchemas(user *entities.User) ([]*entities.Schema,
 		return nil, fmt.Errorf("failed querying all schemas")
 	}
 
+	if user == nil {
+		return nil, fmt.Errorf("cannot get user for tag check")
+	}
+
 	if len(user.Tags) > 0 {
 		var filteredSchemas []*entities.Schema
 		for _, schema := range schemas {

diff --git a/internal/usecases/tag_usecase.go b/internal/usecases/tag_usecase.go
@@ -19,6 +19,10 @@ func (uc *TagUseCase) CreateTag(tag entities.Tag) (*entities.Tag, error) {
 		return nil, fmt.Errorf("failed creating tag: `name` attribute is required")
 	}
 
+	if tag.ViewOrder == 0 {
+		tag.ViewOrder = 1
+	}
+
 	return uc.tagStorage.CreateTag(tag)
 }
 

diff --git a/web/src/features/api-token-edit/model.ts b/web/src/features/api-token-edit/model.ts
@@ -29,7 +29,7 @@ export const editApiTokenFx = createEffect((apiToken: ApiTokenToUpdate) => {
 
 sample({
   source: apiTokenModel.$currentApiToken,
-  target: apiTokenForm.setInitialForm,
+  target: apiTokenForm.setForm,
 });
 
 sample({

diff --git a/web/src/features/schema-edit/model.ts b/web/src/features/schema-edit/model.ts
@@ -143,7 +143,7 @@ export const editSchemaFx = createEffect((schema: SchemaToUpdate) => {
 
 sample({
   source: schemaModel.$currentSchema,
-  target: schemaForm.setInitialForm,
+  target: [schemaForm.setForm],
 });
 
 sample({

diff --git a/web/src/features/tag-edit/model.ts b/web/src/features/tag-edit/model.ts
@@ -29,7 +29,7 @@ export const editTagFx = createEffect((tag: TagToUpdate) => {
 
 sample({
   source: tagModel.$currentTag,
-  target: tagForm.setInitialForm,
+  target: tagForm.setForm,
 });
 
 sample({

diff --git a/web/src/features/user-edit/model.ts b/web/src/features/user-edit/model.ts
@@ -53,7 +53,7 @@ export const editUserFx = createEffect((user: UserToUpdate) => {
 
 sample({
   source: userModel.$currentUser,
-  target: memberForm.setInitialForm,
+  target: memberForm.setForm,
 });
 
 sample({

diff --git a/web/src/shared/auth/index.ts b/web/src/shared/auth/index.ts
@@ -39,7 +39,7 @@ export const createInitialAdmin = createEvent();
 
 sample({
   clock: getSessionFx.doneData,
-  filter: (sessionResponse) => sessionResponse.success && sessionResponse.data.should_create_initial_admin,
+  filter: (sessionResponse) => sessionResponse.success && sessionResponse.data?.should_create_initial_admin,
   target: createInitialAdmin,
 });
 

diff --git a/web/src/shared/routing/middlewares.ts b/web/src/shared/routing/middlewares.ts
@@ -23,7 +23,7 @@ export const chainAuthorized = (route: RouteInstance<any>) => {
   sample({
     source: getSessionFx.doneData,
     filter: (sessionResponse) =>
-      (!sessionResponse?.data?.token || !sessionResponse.success) && !sessionResponse.data.should_create_initial_admin,
+      (!sessionResponse?.data?.token || !sessionResponse.success) && !sessionResponse.data?.should_create_initial_admin,
     target: unauthorizedTriggered,
   });