Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corys contributions #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Corys contributions #1

wants to merge 2 commits into from

Conversation

cwaddingham
Copy link

Problem

The dataset being used was not locally available and had to be downloaded separately from the notebook. Also, the auth credentials for both Pinecone and Neo4j were using locally scoped environment variables, but there was no .env skeleton file to store them. This could result in confusion on how to authenticate to those systems.

Solution

Added kaggle Python module to make downloading the dataset(s) easier, and also cleaned up the auth for Pinecone and Neo4j.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Loaded the notebook in Colab and ran through it manually, confirming it works.

…mand to download the necessary dataset from Kaggle.
…vamped how credentials for Pinecone and Neo4j are handled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant