Feature-based architecture exploration #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulorbe
reviewed
May 3, 2024
Comment on lines
+57
to
+63
| type_translation = { | ||
| 'string': 'str', | ||
| 'integer': 'int', | ||
| 'boolean': 'bool', | ||
| 'array': 'List', | ||
| 'object': 'Dict', | ||
| 'number': 'float' |
There was a problem hiding this comment.
OOC why do you do List (instead of list) and Dict instead of (dict) here?
There was a problem hiding this comment.
(Mostly ask b/c I think Python's moving towards deprecating the typing.<whatever> types in favor of built-ins)
jhamon
force-pushed
the
jhamon/feature-plugin-poc
branch
from
41dbeba
to
4d436ec
Compare
|
I learned a lot from scribbling some ideas here as a POC, but I think it makes sense to pursue code generation in a more careful and rigorous way somewhere outside of this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.