Allow colon inside source tags #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Jun 4, 2024
ssmith-pc
approved these changes
Jun 4, 2024
pinecone/utils/user_agent.py
Outdated
| @@ -11,7 +11,7 @@ def _build_source_tag_field(source_tag): | |||
| # 3. Trim left/right whitespace | |||
| # 4. Condense multiple spaces to one, and replace with underscore | |||
| tag = source_tag.lower() | |||
| tag = re.sub(r'[^a-z0-9_ ]', '', tag) | |||
| tag = re.sub(r'[^a-z0-9_ \:]', '', tag) | |||
There was a problem hiding this comment.
I think it's not necessary to escape the colon if it's used by itself like this
>>> re.sub(r'[^a-z0-9_ :]', '', tag)
'my:tag'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some partners have requested that colon,
:, be added to the set of allowed characters inside source tags.Solution
Add colon to the set of allowed characters.
Type of Change
Test Plan
Unit tests updated to reflect new allowed character.