2024-07 rc #354
Closed
2024-07 rc #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulorbe
reviewed
Jun 13, 2024
| @@ -117,15 +118,17 @@ def Index(self, name: str = '', host: str = '', **kwargs): | |||
| index.query(vector=[...], top_k=10) | |||
| ``` | |||
| """ | |||
| if name == '' and host == '': | |||
| if name == "" and host == "": | |||
There was a problem hiding this comment.
Building off of @ssmith-pc's wisdom, plz remove linting changes from your PRs :)
There was a problem hiding this comment.
We should be running black on all commits to avoid this issue.
## Problem PRs often include formatting changes that makes it difficult to identify changes in functionality ## Solution - Format all code with `black` - Introduce linting `black` linting workflow ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [x] None of the above: (explain here)
# Conflicts: # poetry.lock
|
I'm going to take over this workstream, but I think it will be easiest to start from a fresh branch so I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Candidate (RC) branch client version
5.0.0using x-pinecone-api-version 2024-07.This PR will get merged into
mainwhen we releasepinecone-client==5.0.0(July 15), which is promoted to our2024-07spec - @aulorbeChanges
inference.embed