Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop broken README badge #359

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Drop broken README badge #359

merged 3 commits into from
Jun 21, 2024

Conversation

gdj0nes
Copy link
Contributor

@gdj0nes gdj0nes commented Jun 20, 2024

Problem

CI Badge seems broken

Solution

Remove it

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

@gdj0nes gdj0nes requested a review from jhamon June 20, 2024 15:59
jhamon
jhamon reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you just edit merge.yaml to pr.yaml it will work again as before.

@gdj0nes gdj0nes requested a review from jhamon June 20, 2024 21:03
@gdj0nes gdj0nes merged commit ab3ccfe into main Jun 21, 2024
83 checks passed
@gdj0nes gdj0nes deleted the broken-readme-badge branch June 21, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamon jhamon Awaiting requested review from jhamon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdj0nes @jhamon