Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pinecone-plugin-inference=2.0.0 #397

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

ssmith-pc
Copy link
Contributor

@ssmith-pc ssmith-pc commented Oct 16, 2024

Problem

Updates pinecone-plugin-inference to new major version 2.0.0.

From the 2.0.0 release notes:

Reusing top-level exceptions from pinecone client

Exceptions in the Pinecone Inference SDK have been reworked to throw the top-level exceptions declared in the Pinecone Python SDK as opposed to plugin-specific duplications of those exceptions, which was confusing to users.

Old

Previously, exceptions in the Python Inference SDK were redeclared/duplicated in an obscure package, leading to a poor user experience when working with what should otherwise be standard Pinecone exceptions.

For example, a user who wanted to catch and handle PineconeApiException would have to know to enter:

from pinecone_plugins.inference.core.client.exceptions import PineconeApiException

New

Now, the Inference SDK reuses exceptions from the top-level Pinecone SDK, allowing the user to simply enter:

from pinecone.exceptions import PineconeApiException 

Solution

Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ssmith-pc ssmith-pc merged commit 84068f4 into main Oct 17, 2024
86 checks passed
@ssmith-pc ssmith-pc deleted the ssmith/update-inference branch October 17, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants